This repository was archived by the owner on Jul 4, 2025. It is now read-only.
fix: embedding fixup for nomic-embed-text model #504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vansangpfiev
commented
Apr 15, 2024
context/llama_server_context.h
Outdated
| } else { | ||
| const float* data = llama_get_embeddings(ctx); | ||
| std::vector<float> embedding(data, data + n_embd); | ||
| std::vector<float> embd_res(n_embd, 0.0f); |
Contributor
Author
There was a problem hiding this comment.
API change here for non-logit model
vansangpfiev
changed the title
vansangpfiev
commented
Apr 15, 2024
controllers/llamaCPP.cc
Outdated
|
|
||
| params.n_gpu_layers = jsonBody->get("ngl", 100).asInt(); | ||
| params.n_ctx = jsonBody->get("ctx_len", 2048).asInt(); | ||
| is_embedded_model = |
Contributor
Author
There was a problem hiding this comment.
use embedding flag to check if we should warm up model with embedding or not
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For model like nomic-embed-text-v1.5.f16.gguf, we skip warm up.
Also change the API to send_embedding for non-logits model.